teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
================
Comment at: lldb/test/API/python_api/file_handle/TestFileHandle.py:920
+ self.assertTrue(re.search(r'Show a list of all debugger commands',
output))
+ self.assertTrue(re.search(r'llvm revision', output))
----------------
Can you drop this line? Downstream tends to patch the version output with their
own branding. Maybe `help command alias` and then check for `Define a custom
command in terms of an existing command`.
Also I think you can use `self.assertIn('Show a list of all debugger commands',
output)` here.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D104413/new/
https://reviews.llvm.org/D104413
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
