labath marked 2 inline comments as done.
labath added a comment.
In D112708#3093252 <https://reviews.llvm.org/D112708#3093252>, @teemperor wrote:
> LGTM, could you also extend a non-unit test to test the change within the
> whole FormatManager/etc. setup? I think `TestDataFormatterAdv.py` already has
> a very similar section about ignoring cv on types.
I've added a simple check to that test. I didn't want to go overboard, as I
already have an made an exhaustive test in the follow-up patch.
================
Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:4243
+ ast->getAsConstantArrayType(qual_type)) {
+ arr->getElementType();
+ qual_type = ast->getConstantArrayType(
----------------
teemperor wrote:
> ?
oops
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112708/new/
https://reviews.llvm.org/D112708
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
