aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land.
This is all good of course, but I wonder if we should lift this into the type system and have functions returned a UnstrippedAddress type that you can only turn into an addr_t by calling FixCodeAddress. ================ Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp:2705 actual_class_descriptor_sp = m_runtime.GetClassDescriptorFromISA((ObjCISA)slot_data); + if (!actual_class_descriptor_sp) { ---------------- Why not sink this into m_runtime.GetClassDescriptorFromISA? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112662/new/ https://reviews.llvm.org/D112662 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits