mgorny added inline comments.
================ Comment at: lldb/unittests/Core/CommunicationTest.cpp:80 + std::vector<char> data(1024 * 1024, 0x80); + EXPECT_EQ(write_comm.WriteAll(data.data(), data.size(), conn_status, &error), + data.size()); ---------------- If we want to be super-strict, I can add an another `Write()` call above to verify that a partial write happens — but I'm not sure if we should fail on that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112169/new/ https://reviews.llvm.org/D112169 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
