puremourning added a comment. Thanks for the review!
================ Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/string_view/TestDataFormatterLibcxxStringView.py:62 + ns = self.namespace + self.expect( + "frame variable", ---------------- jingham wrote: > We have lldbtest.expect_var_path for doing this sort of test. It makes these > tests easier to read and less likely to be fooled by accidental matches. Done. There's s slight difference in this API - the null pointer summary returns "" via this api rather than the output which returns "nullptr", so I've inlaced both in the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112222/new/ https://reviews.llvm.org/D112222 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
