jingham added a comment.
It looks like you missed one conversion. I agree with Pavel that None is not
only more pythonic but also more lldbutils-y. Other than those nits, LGTM.
================
Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:648
+ expected_hit_count = -1,
+ location_id = -1,
+ expected_location_hit_count = -1):
----------------
These could be two lists or a list of duples to allow matching against more
than one location at a time, but we can do also that when we need it.
================
Comment at:
lldb/test/API/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py:269
self.expect(side_effect.bp_loc, exe=False,
- patterns=["1.* where = .*main .* resolved, hit count = 1"])
+ patterns=["1.* where = .*main .* resolved,( hardware,)? hit
count = 1"])
----------------
Why didn't you change this one to use your new function?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111899/new/
https://reviews.llvm.org/D111899
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
