mgorny marked 3 inline comments as done.
mgorny added inline comments.
================
Comment at: lldb/source/Plugins/ABI/AArch64/ABIAArch64.cpp:112-118
+ for (int i = 0; i < 32; i++) {
+ x_regs[i] = LLDB_INVALID_REGNUM;
+ v_regs[i] = LLDB_INVALID_REGNUM;
+ have_w_regs[i] = false;
+ have_s_regs[i] = false;
+ have_d_regs[i] = false;
+ }
----------------
labath wrote:
> This might be reason enough to make me replace array<uint32_t> with
> array<Optional<uint32_t> and array<bool> with std::bitset
Makes sense.
================
Comment at: lldb/source/Plugins/ABI/AArch64/ABIAArch64.cpp:149-153
+ for (int i = 0; i < 32; i++) {
+ if (!have_w_regs[i])
+ addPartialRegister(regs, x_regs[i], 8, llvm::formatv("w{0}", i), 4,
+ lldb::eEncodingUint, lldb::eFormatHex);
+ }
----------------
labath wrote:
> It might be worth making a utility function for this as well (or maybe moving
> the for loop into the existing utility function).
I inlined the `for` loop and renamed the function to `addPartialRegisters()`.
================
Comment at:
lldb/test/API/functionalities/gdb_remote_client/TestGDBServerTargetXML.py:383
def writeRegisters(self, reg_hex):
+ reg_data[:] = [reg_hex]
return "OK"
----------------
labath wrote:
> what's up with the [:]? Can we just drop that?
It was necessary to modify the `reg_data` variable from higher function instead
of declaring a new local variable but I think we can move it to class variable
now to make it cleaner.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109876/new/
https://reviews.llvm.org/D109876
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
