teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land.
LGTM. Could you maybe add a `FIXME:` at the end of that comment to point out that the whole 'console' thing isn't implemented/supported. Probably wait and see if Pavel has any objections against this, but I think this is more correct than the old implementation so I think this can land. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111052/new/ https://reviews.llvm.org/D111052 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits