shafik added inline comments.
================ Comment at: llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:838 AttributeList AL = Attrs[i]; - for (unsigned i = AL.index_begin(), e = AL.index_end(); i != e; ++i) { + for (auto i : AL.indexes()) { AttributeSet AS = AL.getAttributes(i); ---------------- You changed this one to `auto` but left the others `unsigned`. I think leaving it as `unsigned` makes more sense since it is not obvious what we expect the type to be here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110885/new/ https://reviews.llvm.org/D110885 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits