clayborg accepted this revision. clayborg added inline comments. This revision is now accepted and ready to land.
================ Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.h:130 - // Given a mangled function name, calculates some alternative manglings since - // the compiler mangling may not line up with the symbol we are expecting - static uint32_t - FindAlternateFunctionManglings(const ConstString mangled, - std::set<ConstString> &candidates); + std::set<ConstString> + GenerateAlternateFunctionManglings(const ConstString mangled) const override; ---------------- Do we need to be using a std::set? Do we need this to be an ordered result? I would think a std::vector would be better no? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109785/new/ https://reviews.llvm.org/D109785 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
