jasonmolenda added a comment.

This is much more comprehensive than what I was thinking of, nicely done.  The 
mapping of the Exception Class in the esr reg to a name is AArch64 specific, 
not Apple specific, isn't it?  I haven't looked in the ARM ARM, but I suspect 
it's just the specific names you're using here which might be what we use at 
apple, but the exception codes are the same for any AArch64 target.

What do you think about printing the FAR register value (in particular) in the 
stop message?  For many exception types, it contains the address that was 
relevant to the fault iirc, and even if we don't explicitly spell out what that 
relationship is (it's prob going to be different for each exception code), just 
having it printed may be helpful for a human reading the message.

I think the patch is fine if you prefer it this way, just giving some other 
ideas.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109795/new/

https://reviews.llvm.org/D109795

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to