mstorsjo created this revision.
mstorsjo added a reviewer: labath.
mstorsjo requested review of this revision.
Herald added a project: LLDB.
These variables are 'size_t' and thus should use %zu. On Windows,
'long' is always 32 bit.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D109779
Files:
lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp
Index: lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp
===================================================================
--- lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp
+++ lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp
@@ -729,7 +729,7 @@
if (error.Fail() || bytes_written != header_size) {
if (bytes_written != header_size)
error.SetErrorStringWithFormat(
- "Unable to write the header. (written %ld/%ld).", bytes_written,
+ "Unable to write the header. (written %zd/%zd).", bytes_written,
header_size);
return error;
}
@@ -740,7 +740,7 @@
if (error.Fail() || bytes_written != m_data.GetByteSize()) {
if (bytes_written != m_data.GetByteSize())
error.SetErrorStringWithFormat(
- "Unable to write the data. (written %ld/%ld).", bytes_written,
+ "Unable to write the data. (written %zd/%zd).", bytes_written,
m_data.GetByteSize());
return error;
}
@@ -752,7 +752,7 @@
if (error.Fail() || bytes_written != directory_size) {
if (bytes_written != directory_size)
error.SetErrorStringWithFormat(
- "Unable to write the directory. (written %ld/%ld).", bytes_written,
+ "Unable to write the directory. (written %zd/%zd).", bytes_written,
directory_size);
return error;
}
Index: lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp
===================================================================
--- lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp
+++ lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp
@@ -729,7 +729,7 @@
if (error.Fail() || bytes_written != header_size) {
if (bytes_written != header_size)
error.SetErrorStringWithFormat(
- "Unable to write the header. (written %ld/%ld).", bytes_written,
+ "Unable to write the header. (written %zd/%zd).", bytes_written,
header_size);
return error;
}
@@ -740,7 +740,7 @@
if (error.Fail() || bytes_written != m_data.GetByteSize()) {
if (bytes_written != m_data.GetByteSize())
error.SetErrorStringWithFormat(
- "Unable to write the data. (written %ld/%ld).", bytes_written,
+ "Unable to write the data. (written %zd/%zd).", bytes_written,
m_data.GetByteSize());
return error;
}
@@ -752,7 +752,7 @@
if (error.Fail() || bytes_written != directory_size) {
if (bytes_written != directory_size)
error.SetErrorStringWithFormat(
- "Unable to write the directory. (written %ld/%ld).", bytes_written,
+ "Unable to write the directory. (written %zd/%zd).", bytes_written,
directory_size);
return error;
}
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
