labath accepted this revision.
labath added inline comments.
This revision is now accepted and ready to land.
================
Comment at:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:3184-3185
+ // Fallback to fstat.
+ llvm::Optional<GDBRemoteFStatData> st = Stat(file_spec);
+ if (st) {
+ file_permissions = st->gdb_st_mode & (S_IRWXU | S_IRWXG | S_IRWXO);
----------------
This is exactly the use case that if-declarations (`if (Optional<...> st =
...)`were designed for.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107811/new/
https://reviews.llvm.org/D107811
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
