teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.

Some nits but this LGTM, thanks! I'll accept & land this for you once the last 
few things are addressed :)



================
Comment at: lldb/tools/lldb-server/lldb-server.cpp:59
     display_usage(progname);
-    exit(option_error);
+    exit(1);
   }
----------------
`return 1;`


================
Comment at: lldb/tools/lldb-server/lldb-server.cpp:67
+    return main_gdbserver(argc, argv);
     break;
+  }
----------------
That break and the ones below are now dead code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108351/new/

https://reviews.llvm.org/D108351

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to