jankratochvil marked 3 inline comments as done.
jankratochvil added a comment.

In D107470#2946689 <https://reviews.llvm.org/D107470#2946689>, @ikudrin wrote:

> `DWARFDebugInfo.TestRnglistsAddressSize`, 
> `DWARFListTableHeader.AddressSize64Offset`, and 
> `DWARFListTableHeader.AddressSize32Offset` pass without applying the patch. 
> Why adding them?

This code has shown it is prone to errors so future changes could break some 
other combination. Better code coverage by the testsuite is AFAIK always 
preferred.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107470/new/

https://reviews.llvm.org/D107470

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to