DavidSpickett added a reviewer: omjavaid.
DavidSpickett added a comment.
Apologies, I missed the ping. A couple of minor comments otherwise this looks
good to me.
@omjavaid Should take a look too as he's doing/did the PAC work for Arm Linux.
I figure this can go in for Mac and be made generic later as needed. (e.g. Arm
Linux won't have the special brk bits)
================
Comment at: lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp:259
+ case llvm::Triple::aarch64: {
+ if (DeterminePtrauthFailure(exe_ctx))
----------------
Don't need the {} here.
================
Comment at: lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp:376
+ case llvm::Triple::aarch64: {
+ if (DeterminePtrauthFailure(exe_ctx))
----------------
Also unneeded {} here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102428/new/
https://reviews.llvm.org/D102428
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
