mib created this revision. mib added reviewers: clayborg, Jim, JDevlieghere. mib added a project: LLDB. mib requested review of this revision. Herald added a subscriber: lldb-commits.
This patch fixes a failure in `TestFunctionStarts.py` that appeared following a change of implementation for synthetic symbol names: https://reviews.llvm.org/D105160 The failure is caused because the previously mentioned patch removes the object file basename from the generated synthetic symbol names to allow them to be shared in the constant string pool. Hence, that last check is not necessary anymore. rdar://80092322 Signed-off-by: Med Ismail Bennani <medismail.benn...@gmail.com> Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D105366 Files: lldb/test/API/macosx/function-starts/TestFunctionStarts.py Index: lldb/test/API/macosx/function-starts/TestFunctionStarts.py =================================================================== --- lldb/test/API/macosx/function-starts/TestFunctionStarts.py +++ lldb/test/API/macosx/function-starts/TestFunctionStarts.py @@ -81,7 +81,6 @@ self.assertTrue(thread.num_frames > 1, "Couldn't backtrace.") name = thread.frame[1].GetFunctionName() self.assertTrue(name.startswith("___lldb_unnamed_symbol")) - self.assertTrue(name.endswith("$$StripMe"))
Index: lldb/test/API/macosx/function-starts/TestFunctionStarts.py =================================================================== --- lldb/test/API/macosx/function-starts/TestFunctionStarts.py +++ lldb/test/API/macosx/function-starts/TestFunctionStarts.py @@ -81,7 +81,6 @@ self.assertTrue(thread.num_frames > 1, "Couldn't backtrace.") name = thread.frame[1].GetFunctionName() self.assertTrue(name.startswith("___lldb_unnamed_symbol")) - self.assertTrue(name.endswith("$$StripMe"))
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits