jingham added a comment. In D104488#2831818 <https://reviews.llvm.org/D104488#2831818>, @clayborg wrote:
> In D104488#2830992 <https://reviews.llvm.org/D104488#2830992>, @jingham wrote: > >> Are the Symbol ID's for unnamed symbols the same each time you read in a >> symbol file? While the unnamed_symbol symbol names are not significant, it >> would be good if you were crashing in __lldb_unnamed_symbol111 on one lldb >> run, you would also crash in the same unnamed symbol when you crashed again. > > Yes, symbol IDs are consistent as they encode the UserID of the symbol as the > number which will be the same on each run as long as the binary doesn't > change. The UserID for synthetic symbols always start with the last valid > actual symbol index from the main symbol table. So the numbers are just as > good as they are before, they just don't start at 1 anymore, the start at the > size of the actual symbol table. Excellent, the specific number is unimportant so long as they are consistent. This seems a side effect of they way they are computed, might be good to drop a judicious comment somewhere saying why it's important... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104488/new/ https://reviews.llvm.org/D104488 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
