omjavaid accepted this revision.
omjavaid added a comment.
This revision is now accepted and ready to land.

In D97281#2824678 <https://reviews.llvm.org/D97281#2824678>, @DavidSpickett 
wrote:

> @omjavaid As it stands, RemoveNonAddressBits here removes the top byte 
> unconditionally.
>
> You asked for pointer signatures to be removed as well, which would be neatly 
> solved by using the ABI plugin. Ok to land this as is, then write a follow up 
> to migrate to using the ABI plugin?

Yes I think this is LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97281/new/

https://reviews.llvm.org/D97281

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to