OmarEmaraDev added inline comments.
================
Comment at:
lldb/test/API/commands/gui/expand-threads-tree/TestGuiExpandThreadsTree.py:38
+ # Exit GUI.
+ self.child.send(escape_key)
+ self.expect_prompt()
----------------
wallace wrote:
> create a method self.exit_gui to dedup some code, as you'll end up doing a
> lot of them as you write your tests
>
> def exit_gui(self):
> self.child.send(chr(27).encode())
> self.expect_prompt()
>
> you can also create a method start_gui
>
> def start_gui(self):
> self.child.sendline("gui")
> self.child.send(chr(27).encode())
>
> you could also later create a base class lldbgui_testcase similar to
> lldbvscode_testcase, where you can put all needed common code
Okay. I will do for all tests in a separate patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100243/new/
https://reviews.llvm.org/D100243
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
