teemperor added inline comments.
================ Comment at: lldb/source/API/SBProcessInfo.cpp:191 + // the string + triple = ConstString(arch.GetTriple().getTriple().c_str()).GetCString(); + } ---------------- brucem wrote: > teemperor wrote: > > You need to 'instrument' these functions. there is a tool called > > `lldb-instr` you can build withint LLDB and you can run that over the file > > to generate the macro stuff for you. > This has the `LLDB_RECORD_METHOD_NO_ARGS` already and is the same as the > other methods in this file. (And it calls `LLDB_REGISTER_METHOD` as well...) My bad, I thought that we needed to put `const char *` inside a `LLDB_RECORD_RESULT` but apparently that's not the case (at least lldb-instr says it's not the case). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103375/new/ https://reviews.llvm.org/D103375 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits