jingham added a comment.

BTW, I generally agree that passing values in parameters that are always going 
to be used internally anyway is ugly and it's better to store them in an ivar.  
But in this case, the value was going to get used in some cases and not in 
others, which storing it as a parameter would have hidden.  That's what I was 
trying to avoid.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102085/new/

https://reviews.llvm.org/D102085

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to