teemperor added a comment. In D101627#2729303 <https://reviews.llvm.org/D101627#2729303>, @DavidSpickett wrote:
>> The_underscore_style_for_functions isn't LLDB (or LLVM) code style. I missed >> that in the first review. So just rename the utility functions to >> TestDumpMultiline and so on and this LGTM. I'm just going to accept this as >> renaming the variables shouldn't need another review. > > I take it that LLDB is also following the variable naming style then? At > least for new code, older code like what this is testing doesn't. We're still following the LLDB style of using_underscores_for_variables and the `m_` prefix for member variables. In a perfect world we would just reformat everything to LLVM code style, but sadly many of us are still anchored in this reality by things such as downstream forks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101627/new/ https://reviews.llvm.org/D101627 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
