DavidSpickett added inline comments.
================
Comment at:
lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:888
+ // consolidated data address mask after ignoring the top byte.
+ if (!ReadPAuthMask().Fail())
+ mask |= m_pac_mask.data_mask;
----------------
I'm guessing this returns a Status, I think that has a .Success().
================
Comment at:
lldb/test/API/commands/watchpoints/watch_tagged_addr/TestWatchTaggedAddress.py:34
+ def test_watch_hit_tagged_ptr_access(self):
+ """Test LLDB hits watchpoints when tagged pointer is used for memory
access"""
+
----------------
These docstrings should be more specific. E.g. this test puts a watchpoint on
an untagged address, where the one below is tagged.
================
Comment at:
lldb/test/API/commands/watchpoints/watch_tagged_addr/TestWatchTaggedAddress.py:103
+
+ self.runCmd("process continue")
+
----------------
You could remove some of the continues by adding a command to the watchpoint:
```
(lldb) watchpoint command add 1 -o continue
```
Then just check the stats at the end after a single continue.
I thought at first this would be bad because you wouldn't know which hit was
missed, but we don't know that with the current setup either.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101361/new/
https://reviews.llvm.org/D101361
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
