clayborg added inline comments.
================
Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:2934
+ // We first find out which variable names are duplicated
+ std::unordered_map<const char *, int> variable_name_counts;
+ for (auto i = start_idx; i < end_idx; ++i) {
----------------
We are getting a variable name via the public API which returns a "const char
*". The only way this works is if the string comes from a ConstString otherwise
there are lifetime issues. So this is and should be ok. The diff you are
talking about was from internal LLDB code. For internal LLDB code we can
enforce this by ensuring that people use ConstString, but externally through
the API, we assume any "const char *" that comes out of it is uniqued and comes
form a ConstString.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99989/new/
https://reviews.llvm.org/D99989
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
