JDevlieghere added a comment. In D100800#2700001 <https://reviews.llvm.org/D100800#2700001>, @teemperor wrote:
> LGTM. I still kinda like the unique_ptr deleter but let's not block bot-fixes > with refactoring requests. I'll open a review for the unique_ptr as a follow > up. > > In D100800#2699984 <https://reviews.llvm.org/D100800#2699984>, @MaskRay wrote: > >> In D100800#2699940 <https://reviews.llvm.org/D100800#2699940>, @teemperor >> wrote: >> >>> Thanks for fixing this, I guess we really need a leak sanitizer/valgrind >>> bot for LLDB... >>> >>> I just have some minor comments but otherwise this LGTM. >> >> Agree.. The 45+ `check-lldb` failures need to be fixed first.. > > Do you have a list of test failures around? Otherwise I can run the test > suite myself when I'm back in the (home) office. We have a sanitized bot that I just revived again. On macOS there's only one more failure remaining. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100800/new/ https://reviews.llvm.org/D100800 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
