labath added inline comments.
================
Comment at:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:2102
+ if (pid == StringExtractorGDBRemote::AllProcesses)
+ return SendUnimplementedResponse("Selecting all processes not supported");
+ if (pid == LLDB_INVALID_PROCESS_ID)
----------------
Does it ever make sense to have more than one (process or thread) selected? If
not, an error response may be more appropriate..
================
Comment at:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.h:234
const llvm::ArrayRef<llvm::StringRef> client_features) override;
-
private:
----------------
revert
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100261/new/
https://reviews.llvm.org/D100261
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
