aganea added a comment.
I am still concerned by the fact that this patch doesn't fix the issue
mentionned in https://reviews.llvm.org/D96363#2650460
Was the intention to fix that issue? Will the fix be done in a subsequent patch?
================
Comment at: llvm/lib/Support/Windows/Path.inc:1087
+ if (Flags & OF_CRLF) {
+ assert(Flags & OF_Text, "Flags set OF_CRLF without OF_Text");
CrtOpenFlags |= _O_TEXT;
----------------
`s/,/ &&/`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D99426/new/
https://reviews.llvm.org/D99426
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
