I think the first two test just need the "llgs" test category, since debugserver (obviously) does not support the extension. I don't see TestGdbserverPort.test failing in the latest build on that page (and I'd be surprised if this was related to that, so I suspect that was just flake.

pl

On 01/04/2021 11:06, Jason Molenda wrote:
Hi Michał, this commit has caused a test failure on the macos incremental CI 
bot,

http://green.lab.llvm.org/green/blue/organizations/jenkins/lldb-cmake/activity

Failed Tests (3):

   lldb-api :: tools/lldb-server/TestLldbGdbServer.py
   lldb-api :: tools/lldb-server/vCont-threads/TestGdbRemote_vContThreads.py
   lldb-shell :: lldb-server/TestGdbserverPort.test

I know this commit caused the TestLldbGdbServer.py for sure, I'm pretty sure it 
caused TestGdbRemote_vContThreads.py, I haven't tested TestGdbserverPort.test 
yet.  It's probably best to revert the change until we can debug what is 
happening here (I can look tomorrow) so the CI bots aren't all red for macos.


On Mar 30, 2021, at 6:09 AM, Michał Górny via Phabricator via lldb-commits 
<lldb-commits@lists.llvm.org> wrote:

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG6c1a8039de46: [lldb] [server] Support for multiprocess 
extension (authored by mgorny).
Herald added a project: LLDB.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98482/new/

https://reviews.llvm.org/D98482

Files:
  lldb/include/lldb/Utility/StringExtractorGDBRemote.h
  lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.h
  lldb/source/Utility/StringExtractorGDBRemote.cpp
  lldb/test/API/tools/lldb-server/TestGdbRemote_vContThreads.py
  lldb/test/API/tools/lldb-server/TestLldbGdbServer.py
  lldb/unittests/Utility/CMakeLists.txt
  lldb/unittests/Utility/StringExtractorGDBRemoteTest.cpp

<D98482.334133.patch>_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits


_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to