shafik added inline comments.
================ Comment at: lldb/test/API/macosx/lc-note/firmware-corefile/TestFirmwareCorefiles.py:142 + main_addr = main_sym.GetStartAddress() + self.assertGreater(main_addr.GetLoadAddress(self.target), 0x70000000000) + self.assertNotEqual(main_addr.GetLoadAddress(self.target), lldb.LLDB_INVALID_ADDRESS) ---------------- `0x70000000000` feels like it should be a variable with a name since we are using in multiple places. ================ Comment at: lldb/test/API/macosx/lc-note/firmware-corefile/create-empty-corefile.cpp:90 + char buf[24]; + sprintf(buf, "0x%llx", address); + ident += buf; ---------------- `snprintf` we should also collect the return value and assert on the result. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99571/new/ https://reviews.llvm.org/D99571 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
