mgorny added inline comments.

================
Comment at: lldb/test/Shell/Subprocess/fork-follow-parent.test:6
+process launch
+# CHECK: function run in child
+# CHECK-NOT: function run in parent
----------------
labath wrote:
> mgorny wrote:
> > The tests sometimes fail if child starts after the breakpoint is hit (and 
> > therefore this check happens before stop reason below). Any suggestion how 
> > to make it work independently of where 'function run in child' happens?
> There are several ways around that, but I don't know which one is the best, 
> as I'm not sure what exactly you're trying to test. You could try to capture 
> this nondeterminism with CHECK-DAGs, but CHECK-DAGs don't combine well with 
> CHECK-NOTs. Another option is to make this predictable by adding 
> synchronization to the inferior. If you just wanted to check that the child 
> process finishes correctly, you could have the parent process check its exit 
> status and match that...
The goal is to check that parent is stopped before printing but the child is 
not. I suppose your last suggestion, i.e. checking for exit status, should be 
good enough.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98822/new/

https://reviews.llvm.org/D98822

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to