labath added a comment. I'm not that familiar with this function, but the output seems right. Given that the `show_inline_callsite_line_info` argument is no longer used, can you remove it?
================ Comment at: lldb/source/Symbol/SymbolContext.cpp:133 + // fill it in correctly with the calling file and line. Previous code + // was extracting the calling file and line from inlined_block_info and + // using it right away which is not correct. On the first call to this ---------------- I'm not sure if describing the old behavior of deleted code is that helpful. This may be better off in the commit message. ================ Comment at: lldb/test/Shell/Commands/command-image-lookup.yaml:129 + reserved3: 0x0 + - sectname: __debug_pubnames + segname: __DWARF ---------------- Could we delete pub***, aranges, and apple_*** sections? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98761/new/ https://reviews.llvm.org/D98761 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
