labath accepted this revision.
labath added inline comments.

================
Comment at: 
lldb/test/API/commands/register/register/aarch64_dynamic_regset/TestArm64DynamicRegsets.py:59-60
+                         for _ in range(p_reg_size)) + '}'
+            self.runCmd('register write p%i' %
+                        (i) + " '" + p_regs_value + "'")
+            self.expect('register read p%i' % (i), substrs=[p_regs_value])
----------------
I find this combination of %-formatting and string concatenation unsettling. 
Just use % for the whole string?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96463/new/

https://reviews.llvm.org/D96463

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to