mgorny added inline comments.

================
Comment at: lldb/include/lldb/Host/common/NativeProcessProtocol.h:145
 
+  // Remove all software breakpoints and return a vector of breakpoint data
+  // that can be used to readd them.
----------------
mgorny wrote:
> Long term, these functions are probably unnecessary. It just occurred to me 
> to check how GDB handles it, and it handles clearing and restoring 
> breakpoints on client side (i.e. by sending `z` and `Z` packets).
Hmm, actually that depends on how much compatibility with old client versions 
we want to preserve. If we want forks/vforks to stop being broken with 
breakpoints when using an old client, we need to keep them as a fallback logic 
for when fork/vfork-events aren't supported by client.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98822/new/

https://reviews.llvm.org/D98822

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to