[Lldb-commits] [PATCH] D98529: Strip pointer authentication codes from aarch64 pc.

[Justin Cohen via Phabricator via lldb-commits]

justincohen created this revision.
Herald added subscribers: omjavaid, danielkiss, kristof.beyls.
justincohen requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D98529

Files:
  lldb/source/Plugins/ABI/AArch64/ABIAArch64.cpp
  lldb/source/Plugins/ABI/AArch64/ABIAArch64.h


Index: lldb/source/Plugins/ABI/AArch64/ABIAArch64.h
===================================================================
--- lldb/source/Plugins/ABI/AArch64/ABIAArch64.h
+++ lldb/source/Plugins/ABI/AArch64/ABIAArch64.h
@@ -24,6 +24,8 @@
 
   uint32_t GetGenericNum(llvm::StringRef name) override;
 
+  lldb::addr_t FixCodeAddress(lldb::addr_t pc) override;
+
   using lldb_private::MCBasedABI::MCBasedABI;
 };
 #endif
Index: lldb/source/Plugins/ABI/AArch64/ABIAArch64.cpp
===================================================================
--- lldb/source/Plugins/ABI/AArch64/ABIAArch64.cpp
+++ lldb/source/Plugins/ABI/AArch64/ABIAArch64.cpp
@@ -56,3 +56,9 @@
       .Case("x7", LLDB_REGNUM_GENERIC_ARG8)
       .Default(LLDB_INVALID_REGNUM);
 }
+
+lldb::addr_t ABIAArch64::FixCodeAddress(lldb::addr_t pc) {
+  // Short term workaround to remove any pointer authentication codes. This
+  // should be removed once full PAC support is added.
+  return pc & 0x0000000FFFFFFFFF;
+}



Index: lldb/source/Plugins/ABI/AArch64/ABIAArch64.h
===================================================================
--- lldb/source/Plugins/ABI/AArch64/ABIAArch64.h
+++ lldb/source/Plugins/ABI/AArch64/ABIAArch64.h
@@ -24,6 +24,8 @@
 
   uint32_t GetGenericNum(llvm::StringRef name) override;
 
+  lldb::addr_t FixCodeAddress(lldb::addr_t pc) override;
+
   using lldb_private::MCBasedABI::MCBasedABI;
 };
 #endif
Index: lldb/source/Plugins/ABI/AArch64/ABIAArch64.cpp
===================================================================
--- lldb/source/Plugins/ABI/AArch64/ABIAArch64.cpp
+++ lldb/source/Plugins/ABI/AArch64/ABIAArch64.cpp
@@ -56,3 +56,9 @@
       .Case("x7", LLDB_REGNUM_GENERIC_ARG8)
       .Default(LLDB_INVALID_REGNUM);
 }
+
+lldb::addr_t ABIAArch64::FixCodeAddress(lldb::addr_t pc) {
+  // Short term workaround to remove any pointer authentication codes. This
+  // should be removed once full PAC support is added.
+  return pc & 0x0000000FFFFFFFFF;
+}

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits