Author: Raphael Isemann Date: 2021-02-25T11:44:19+01:00 New Revision: 2d6b767c1d15ec736b409370da33009de57de7f2
URL: https://github.com/llvm/llvm-project/commit/2d6b767c1d15ec736b409370da33009de57de7f2 DIFF: https://github.com/llvm/llvm-project/commit/2d6b767c1d15ec736b409370da33009de57de7f2.diff LOG: [lldb][NFC] Remove some obsolete comments in ClangASTImporter.cpp The first two comments are incomplete and reference obsolete code. The last one is just commented out code (that also doesn't look correct). Added: Modified: lldb/source/Plugins/ExpressionParser/Clang/ClangASTImporter.cpp Removed: ################################################################################ diff --git a/lldb/source/Plugins/ExpressionParser/Clang/ClangASTImporter.cpp b/lldb/source/Plugins/ExpressionParser/Clang/ClangASTImporter.cpp index c1c115c1fe74..ad72f01f4060 100644 --- a/lldb/source/Plugins/ExpressionParser/Clang/ClangASTImporter.cpp +++ b/lldb/source/Plugins/ExpressionParser/Clang/ClangASTImporter.cpp @@ -359,9 +359,6 @@ bool ClangASTImporter::CanImport(const CompilerType &type) { if (!ClangUtil::IsClangType(type)) return false; - // TODO: remove external completion BOOL - // CompleteAndFetchChildren should get the Decl out and check for the - clang::QualType qual_type( ClangUtil::GetCanonicalQualType(ClangUtil::RemoveFastQualifiers(type))); @@ -435,8 +432,6 @@ bool ClangASTImporter::CanImport(const CompilerType &type) { bool ClangASTImporter::Import(const CompilerType &type) { if (!ClangUtil::IsClangType(type)) return false; - // TODO: remove external completion BOOL - // CompleteAndFetchChildren should get the Decl out and check for the clang::QualType qual_type( ClangUtil::GetCanonicalQualType(ClangUtil::RemoveFastQualifiers(type))); @@ -908,16 +903,6 @@ void ClangASTImporter::ASTImporterDelegate::ImportDefinitionTo( MapImported(from, to); ASTImporter::Imported(from, to); - /* - if (to_objc_interface) - to_objc_interface->startDefinition(); - - CXXRecordDecl *to_cxx_record = dyn_cast<CXXRecordDecl>(to); - - if (to_cxx_record) - to_cxx_record->startDefinition(); - */ - Log *log = lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_EXPRESSIONS); if (llvm::Error err = ImportDefinition(from)) { _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
