omjavaid added a comment. In D96458#2566347 <https://reviews.llvm.org/D96458#2566347>, @labath wrote:
> I'm sorry, my response times are pretty slow these days. > > I'm thinking about this `ConfigureRegisterInfos` business. I get that the > vector length is variable, and so we need to refresh it after every stop. > However, the set of enabled extensions seems more static. > > Is it possible for that to change during the lifetime of the process? I'd > guess not, because otherwise we'd have to also resend the register lists > after every stop. And, if that's the case, I'm wondering if there's a way to > reflect this static-ness in the code. For example, by doing this setup in the > constructor, instead of a late `ConfigureRegisterInfos` call. IIRC, the > register contexts are created when the thread is stopped, so it should be > possible to fetch the information about supported registers quite early. > > What do you think? Yes that is doable. I ll move ConfigureRegisterInfos part into constructor. ================ Comment at: lldb/source/Plugins/Process/Utility/RegisterInfoPOSIX_arm64.h:17-18 +#define ARM64_REGS_CONFIG_DEFAULT 0x00 +#define ARM64_REGS_CONFIG_SVE 0x01 + ---------------- labath wrote: > let's not use macros here. Ack. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96458/new/ https://reviews.llvm.org/D96458 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
