omjavaid added inline comments.

================
Comment at: 
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:950
   // We are ready to exit the debug monitor.
   m_exit_now = true;
   m_mainloop.RequestTermination();
----------------
May be we can set m_exit_now instead of setting done, or interrupt. if we have 
to exit on empty response.


================
Comment at: 
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:1064
+
+    if (done || interrupt) {
+      m_mainloop.RequestTermination();
----------------
GDBRemoteCommunicationServer::GetPacketAndSendResponse sets done on 
eServerPacketType_invalid (empty packet) wouldnt termination be too strict for 
that case. 



Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97017/new/

https://reviews.llvm.org/D97017

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
  • [Lldb-commits] [PAT... Jonas Devlieghere via Phabricator via lldb-commits
    • [Lldb-commits]... Muhammad Omair Javaid via Phabricator via lldb-commits
    • [Lldb-commits]... Pavel Labath via Phabricator via lldb-commits

Reply via email to