teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed.
(I'm very sorry for the delay, that slipped out of my review queue.) Wouldn't changing this logic to an explicit `get_target_property` call break the multi-config projects (where there are multiple possible paths)? I actually think the easiest solution is to just delete the `file(MAKE_DIRECTORY ...` line. As you described it's not doing what it should and as we create the directory in the custom command below it is redundant. I believe this line is only a remnant from when I tried to get this working in non-multi-config generator setups. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95185/new/ https://reviews.llvm.org/D95185 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
