djtodoro added a comment. (@labath Sorry for late response, I've been away from keyboard for some time.)
> Have you by any chance learned why are we zero-filling this buffer in the > first place? Seems like an odd thing to do... Maybe we should just stop > zero-filling completely? Hmm... not sure why. It was there since the original commit that introduced the file (c037383aff81a61ed956858353ec003e970fb2ce). I don't see the point actually, and when I removed the `zero_fill_size` and zero filling with `memset()`, there was no regression in the lldb test suite. I guess we can remove it completely. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93939/new/ https://reviews.llvm.org/D93939 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
