clayborg added inline comments.
================
Comment at:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:359-366
+ if (!include_existing) {
+ // Create the excluded process list before polling begins.
+ Host::FindProcesses(match_info, exclusion_list);
+ LLDB_LOG(log, "placed '{0}' processes in the exclusion list.",
+ exclusion_list.size());
+ } else {
+ LLDB_LOG(log, "including existing processes in search");
----------------
Reverse this logic and switch the if/else contents?
================
Comment at:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:371
+ StreamString name_with_slash_stream;
+ name_with_slash_stream.Format("/{0}", process_name);
+ auto name_with_slash = name_with_slash_stream.GetString();
----------------
Do we need to get the correct directory delimiter for the current platform
here? This will work for everything except windows. Just wanted to bring this
up in case we do.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94672/new/
https://reviews.llvm.org/D94672
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
