labath added a comment.
Using remote numbers in the lists seems reasonable as well, but I am troubled
by the "opportunistic" aspect of the implementation. This pattern
uint32_t lldb_regnum = ConvertRegisterKindToRegisterNumber(
eRegisterKindProcessPlugin, reg);
if (lldb_regnum != LLDB_INVALID_REGNUM)
reg = lldb_regnum;
const RegisterInfo *value_reg_info = GetRegisterInfoAtIndex(reg);
is cumbersome to write and easy to get wrong.
Why are we sometimes **not** using the plugin/remote number? Could we make it
so that this number is used unconditionally?
Then all of this could become: `const RegisterInfo *value_reg_info =
GetRegisterInfo(eRegisterKindProcessPlugin, reg)`
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77043/new/
https://reviews.llvm.org/D77043
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
