JDevlieghere marked 2 inline comments as done.
JDevlieghere added inline comments.


================
Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp:98-99
+PlatformSP PlatformMacOSX::CreateInstance(bool force, const ArchSpec *arch) {
+  // The only time we create an instance is when we are creating a remote
+  // macosx platform which is handled by PlatformRemoteMacOSX.
+  return PlatformSP();
----------------
clayborg wrote:
> Where again do we create the host platform then?
On line 58 in `PlatformMacOSX::Initialize`


================
Comment at: lldb/test/API/commands/platform/sdk/main.c:4-6
+  for (int i = 0; i != 10; ++i) {
+    sleep(10);
+  }
----------------
clayborg wrote:
> You can call pause() which will stop and wait for a signal to be delivered to 
> the program if you don't want to call sleep. When the debugger attaches, this 
> will cause the pause() to exit when you continue the process.
Oh cool, learned something new today! 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92452/new/

https://reviews.llvm.org/D92452

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to