labath accepted this revision. labath added a comment. This revision is now accepted and ready to land.
I was just asking for comments on the two constructors, but having them elsewhere is nice too. ================ Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.h:29-31 + // This class is used to restrict the range of ports that + // platform created debugserver/gdbserver processes will + // communicate on. ---------------- This looks like a class-level comment. Could you also say a few words about what the constructor does specifically. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91634/new/ https://reviews.llvm.org/D91634 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits