DavidSpickett added inline comments.
================ Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp:197 #endif - uint16_t *port_ptr = &port; + uint16_t *port_ptr = port.getPointer(); if (m_socket_protocol == Socket::ProtocolTcp) { ---------------- I know this is a bit unorthodox but things got messy trying to pass an Optional into StartDebugServerProcess. So I figured it's better to keep StartDebugServerProcess the same for now and limit the scope of any mistakes. (the logic gets quite hard to follow) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92035/new/ https://reviews.llvm.org/D92035 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits