This revision was automatically updated to reflect the committed changes.
Closed by commit rG9367b57dadb7: [lldb] [test] Fix qRegisterInfo lldb-server
tests to handle missing registers (authored by mgorny).
Herald added a project: LLDB.
Changed prior to commit:
https://reviews.llvm.org/D91922?vs=306871&id=306966#toc
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91922/new/
https://reviews.llvm.org/D91922
Files:
lldb/test/API/tools/lldb-server/TestLldbGdbServer.py
Index: lldb/test/API/tools/lldb-server/TestLldbGdbServer.py
===================================================================
--- lldb/test/API/tools/lldb-server/TestLldbGdbServer.py
+++ lldb/test/API/tools/lldb-server/TestLldbGdbServer.py
@@ -585,9 +585,15 @@
p_response = context.get("p_response")
self.assertIsNotNone(p_response)
+ # Skip erraneous (unsupported) registers.
+ # TODO: remove this once we make unsupported registers disappear.
+ if p_response.startswith("E") and len(p_response) == 3:
+ continue
+
if "dynamic_size_dwarf_expr_bytes" in reg_info:
self.updateRegInfoBitsize(reg_info, byte_order)
- self.assertEqual(len(p_response), 2 * int(reg_info["bitsize"]) / 8)
+ self.assertEqual(len(p_response), 2 * int(reg_info["bitsize"]) / 8,
+ reg_info)
# Increment loop
reg_index += 1
@@ -601,7 +607,7 @@
self.set_inferior_startup_launch()
self.p_returns_correct_data_size_for_each_qRegisterInfo()
- @expectedFailureAll(oslist=["freebsd", "netbsd"])
+ @expectedFailureAll(oslist=["netbsd"])
@llgs_test
def test_p_returns_correct_data_size_for_each_qRegisterInfo_launch_llgs(
self):
@@ -619,7 +625,7 @@
self.set_inferior_startup_attach()
self.p_returns_correct_data_size_for_each_qRegisterInfo()
- @expectedFailureAll(oslist=["freebsd", "netbsd"])
+ @expectedFailureAll(oslist=["netbsd"])
@llgs_test
def test_p_returns_correct_data_size_for_each_qRegisterInfo_attach_llgs(
self):
Index: lldb/test/API/tools/lldb-server/TestLldbGdbServer.py
===================================================================
--- lldb/test/API/tools/lldb-server/TestLldbGdbServer.py
+++ lldb/test/API/tools/lldb-server/TestLldbGdbServer.py
@@ -585,9 +585,15 @@
p_response = context.get("p_response")
self.assertIsNotNone(p_response)
+ # Skip erraneous (unsupported) registers.
+ # TODO: remove this once we make unsupported registers disappear.
+ if p_response.startswith("E") and len(p_response) == 3:
+ continue
+
if "dynamic_size_dwarf_expr_bytes" in reg_info:
self.updateRegInfoBitsize(reg_info, byte_order)
- self.assertEqual(len(p_response), 2 * int(reg_info["bitsize"]) / 8)
+ self.assertEqual(len(p_response), 2 * int(reg_info["bitsize"]) / 8,
+ reg_info)
# Increment loop
reg_index += 1
@@ -601,7 +607,7 @@
self.set_inferior_startup_launch()
self.p_returns_correct_data_size_for_each_qRegisterInfo()
- @expectedFailureAll(oslist=["freebsd", "netbsd"])
+ @expectedFailureAll(oslist=["netbsd"])
@llgs_test
def test_p_returns_correct_data_size_for_each_qRegisterInfo_launch_llgs(
self):
@@ -619,7 +625,7 @@
self.set_inferior_startup_attach()
self.p_returns_correct_data_size_for_each_qRegisterInfo()
- @expectedFailureAll(oslist=["freebsd", "netbsd"])
+ @expectedFailureAll(oslist=["netbsd"])
@llgs_test
def test_p_returns_correct_data_size_for_each_qRegisterInfo_attach_llgs(
self):
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
