labath added inline comments.
================
Comment at:
lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp:534
+ // TODO
+ if (reg_info->kinds[lldb::eRegisterKindLLDB] == lldb_ftag_x86_64) {
+ uint8_t abridged_tw = *(uint8_t *)src;
----------------
mgorny wrote:
> labath wrote:
> > mgorny wrote:
> > > @labath, any suggestion what kind of test to use here? Maybe against
> > > `&m_xstate->fxsave.ftag` address?
> > You mean, like, how to detect that we're dealing with the ftag register?
> >
> > This approach seems reasonable to me..
> This = checking register number like in the code (in which I suppose we'd
> have to move distinguishing amd64/i386 to ctor like `first_fpr`? Or checking
> for actual pointer as I suggested in the comment?
I originally meant the register number approach, but I see what you mean now.
I think that going off of the address is perfectly fine...
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91504/new/
https://reviews.llvm.org/D91504
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
