omjavaid added a comment.

In D91241#2391072 <https://reviews.llvm.org/D91241#2391072>, @labath wrote:

> This looks pretty straightforward, modulo the inline comment about the 
> centralization of the offset computations....

So the current approach of finalizing offsets of pseudo registers after 
receiving/processing all registers is because in case of SVE we define FPU 
register set first containing V, D, S  pseudo registers first and then define 
SVE registers set where their primary register Z is defined.

We have choice of either documenting that all pseudo register should come after 
their corresponding primary register are defined and make this change to SVE 
register definitions as well where we are not enforcing this principle mainly 
due to consistency with non-SVE vs SVE register sets..


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91241/new/

https://reviews.llvm.org/D91241

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to