JDevlieghere marked an inline comment as done. JDevlieghere added a comment.
In D91130#2387390 <https://reviews.llvm.org/D91130#2387390>, @clayborg wrote: > JSON crash logs are almost here??? I remember asking for those back when I > was at Apple! Great news. Yep! 🥳 > It would be nice to have a crash log from a small but real process we might > be able to load as an end to end test? I'd be happy to, but is there a way to test the crashlog script without having a `dsymForUUID`? ================ Comment at: lldb/examples/python/crashlog.py:413-414 + self.parse_process_info(self.data) + self.parse_images(self.data['usedImages']) + self.parse_threads(self.data['threads']) + ---------------- clayborg wrote: > you ok with this raising throwing an exception when/if these key/value pairs > are not in the file? Yeah, at least initially. It appears the format is still not locked down, so I hope this will give us more signal when things end up changing. But good point, long term we should be more defensive. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91130/new/ https://reviews.llvm.org/D91130 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
