teemperor added a comment. In D91193#2386832 <https://reviews.llvm.org/D91193#2386832>, @kastiglione wrote:
> @teemperor maybe? Do you mean validation should go in `runCmd`? Or do you > mean something else? I meant that to my knowledge command execution where the only expectation is that they succeed (so, no output checking) are supposed to be done via `runCmd`. `expect` is also documented as `Similar to runCmd; with additional expect style output matching ability.`, so if we allow calling `expect` without the additional `expect style matching ability`, then we might as well remove `runCmd`. So IMHO the current implementation of expect is just fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91193/new/ https://reviews.llvm.org/D91193 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits